Changes in Makefile.libcompat

e84374d38bc1690eb62de75874348b1cfa21ea93 - Makefile.libcompat: Use same PATH for _lc_build-tools as _build-tools

Fri, 22 Aug 2025 22:46:15 +0200

Makefile.libcompat: Use same PATH for _lc_build-tools as _build-toolsWithout this, we end up with just the host's tools in PATH during_lc_build-tools. In particular, sed on GNU/Linux systems will be GNUsed, whose -i option has different semantics, and this causes the lib32build of ncurses to fail trying to create curses.h with: sed: can't read s|...|...|g: No such file or directoryThis has always been a bug in Makefile.libcompat but previously itdidn't end up mattering; this is the first known case.Fixes: 1cc020eba69e ("ncurses: Provide reproducible paths")MFC after: 1 week List of files: /freebsd/Makefile.libcompat

c6778f3a4423743a3f30d8d09bc4e4a086863928 - Makefile.libcompat: Tweak krb5 compat dirs

Sun, 17 Aug 2025 03:19:21 +0200

Makefile.libcompat: Tweak krb5 compat dirskrb5/util contains both programs and libraries; trying to build thatfor compat confuses bsd.prog.mk and results in unwanted files beingcreated in the source tree. Remove krb5/util and instead list onlythe directories underneath krb5/util which contain libraries.The libdata change from the diff isn't included; that will be fixedin a different way.Fixes: fb13ae28b2e8 ("Makefile.libcompat: Add krb5/util")Reviewed by: ngie (previous version)Differential Revision: https://reviews.freebsd.org/D51937 List of files: /freebsd/Makefile.libcompat

fb13ae28b2e816d35b229c0d8ebadb4e322fb4eb - Makefile.libcompat: Add krb5/util

Sat, 16 Aug 2025 21:58:18 +0200

Makefile.libcompat: Add krb5/utilThis fixes missing libraries (libcom_err, libkrb5profile, ...)for the 32-bit build, since these libraries live in krb5/util.Reviewed by: ngie, desDifferential Revision: https://reviews.freebsd.org/D51926 List of files: /freebsd/Makefile.libcompat

7e35117eb07f86c385656ecc6a2a92093be98131 - Makefile: Hook MIT KRB5 into the build

Wed, 11 Jun 2025 04:57:54 +0200

Makefile: Hook MIT KRB5 into the buildAdd tests for MK_MITKRB5. If "yes" build MIT KRB5. If "no" build Heimdal.The default is MK_MITKRB5 = no, added by "krb5: Add build plumbing".At some point we will change the default to MK_MITKRB5 = yes. A portsexp-run will need to be successfully run first.Sponsored by: The FreeBSD FoundationDifferential revision: https://reviews.freebsd.org/D50815 List of files: /freebsd/Makefile.libcompat

8e35800732573de6c4bc1dd3ac420447fca96231 - build: remove the last vestiges of lint support

Fri, 06 Jun 2025 01:55:34 +0200

build: remove the last vestiges of lint supportCommit 1cbb58886a47 (shipped in 12.0.0) removed all lint infrastructure.A bunch of NO_LINT definitions remained (perhaps as a bootstrappingmeasture). Remove them.Reviewed by: emasteDifferential Revision: https://reviews.freebsd.org/D50704 List of files: /freebsd/Makefile.libcompat

e9ac41698b2f322d55ccf9da50a3596edb2c1800 - Remove residual blank line at start of Makefile

Mon, 15 Jul 2024 06:46:32 +0200

Remove residual blank line at start of MakefileThis is a residual of the $FreeBSD$ removal.MFC After: 3 days (though I'll just run the command on the branches)Sponsored by: Netflix List of files: /freebsd/Makefile.libcompat

834f73d253581dba80a2d67a7c06b102b78c8a58 - build{libcompat}: Pass UNIVERSE_TOOLCHAIN_PATH to the _lc_build-tools submake

Tue, 22 Aug 2023 06:00:45 +0200

build{libcompat}: Pass UNIVERSE_TOOLCHAIN_PATH to the _lc_build-tools submakeThis fixes make UNIVERSE_TOOLCHAIN=yes with libcompats.Reviewed by: jrtc27Differential Revision: https://reviews.freebsd.org/D41535 List of files: /freebsd/Makefile.libcompat

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 19:55:03 +0200

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd/Makefile.libcompat

8aaa1230899239a90f35e73436377a6f5f79bbf9 - Makefile.libcompat: Fix DTRACE variable

Fri, 11 Aug 2023 01:48:01 +0200

Makefile.libcompat: Fix DTRACE variableBack when Makefile.lib32 was turned into Makefile.libcompat, a typo wasintroduced; it should have been LIBCOMPATDTRACE, but instead gained adollar sign in it as LIB$COMPATDTRACE (and with COMPATDTRACE not beingdefined, was equivalent to ${LIB:U${DTRACE}}). This then meant it wasnot converted to LIB${_LIBCOMPAT}DTRACE in 91d7edd549f5 ("Generaliselibcompat to be a list rather than a single option") and instead leftbroken. Belatedly fix this long-standing seemingly-inconsequential bug.Fixes: dba75e9fa5a9 ("Move Makefile.lib32 to Makefile.libcompat and generalize it.") List of files: /freebsd/Makefile.libcompat

1c02497648bdf61a43dd271f6f9171a037046d8e - Makefile.inc1: Enable requesting the universe toolchain.

Tue, 01 Aug 2023 23:01:57 +0200

Makefile.inc1: Enable requesting the universe toolchain.make universe builds a cross toolchain under HOST_OBJTMP/tmp via theuniverse-toolchain target. However, doing a plain 'make buildworld'after a universe/tinderbox run (e.g. to reproduce a failure and testthe fix for it), will try to build a new cross toolchain underOBJTMP/tmp which can be tedious. This commit adds a make variable(UNIVERSE_TOOLCHAIN) which can be used similar to CROSS_TOOLCHAIN torequest an external toolchain. If this variable is set (value doesn'tmatter), the the universe toolchain is used as an external toolchain.Reviewed by: impDifferential Revision: https://reviews.freebsd.org/D40777 List of files: /freebsd/Makefile.libcompat

a1b67573130114257fdd443c4ec9b54fbe2e5843 - arm64 lib32: enable building of lib32 on arm64

Wed, 26 Jul 2023 01:59:52 +0200

arm64 lib32: enable building of lib32 on arm64Enable LIB32 option on aarch64, defaulting to YES; it had defaultedto "broken". Add required variables for how to compile lib32 onarm. Use /usr/include/arm for armv7 (32-bit) headers, analogous to/usr/include/i386 on amd64. Omit libomp from lib32; it is notsupported on armv7.Reviewed by: jrtc27Differential Revision: https://reviews.freebsd.org/D40945 List of files: /freebsd/Makefile.libcompat

5d4f8df451aa942701ecfced80516f3584b589d9 - Makefile.libcompat: Make quoting for CC/CXX/CPP more future-proof

Fri, 14 Jul 2023 06:34:03 +0200

Makefile.libcompat: Make quoting for CC/CXX/CPP more future-proofbmake's :Q is for quoting outside of double quotes, but here is insidedouble quotes, and as a result it ends up quoting characters that don'thave a special meaning inside double quotes. On the surface this wouldseem harmless, but POSIX sh has a strange behaviour (differing fromoutside double quotes) that, inside double quotes, a backslash before acharacter that never has a special meaning inside double quotes ispassed through. As a result, should LIB${_LIBCOMPAT}CFLAGS containsomething like -DFOO$x$=x, we would form "... -DFOO\\$x\\$=x ...",which would be parsed as -DFOO\$x\$=x, since the parentheses are neverspecial inside double quotes (but the backslash itself is), not theoriginal -DFOO$x$=x as intended.Instead, construct the whole string as a bmake expression and use :Q onthat, without the manual double quotes around everything. Note that the:L modifier lets you treat an expression like a variable expansion andapply modifiers to it, i.e. ${expr:L:...} is the same as tmp=expr${tmp:...} (in essence, ignoring possible differences due to deferredsubstitution).Improves: 537f945fc89f ("Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make") List of files: /freebsd/Makefile.libcompat

0a5e35a7b1811308bcb2aa2e6c7e7bd49dfc9770 - Makefile.libcompat: Be consistent about not installing includes

Fri, 14 Jul 2023 03:36:04 +0200

Makefile.libcompat: Be consistent about not installing includesCurrently we only pass MK_INCLUDES=no for distribute and install, sinceit's only in LIB${_LIBCOMPAT}IMAKE, which means that we enable includesduring libraries and thus install includes into worldtmp, despite itbeing shared these days across native and libcompats. This also meanswe're at risk of having headers needed for building against a libcompatthat don't get installed to the system, but do end up being installed toworldtmp. In particular, lib/msun has different fenv.h for aarch64 andarm, so aarch64 will need arm's copy when it grows lib32 support, andthis would be installed to worldtmp, but not to the system, meaning anyprograms that use fenv.h wouldn't be able to be built.Instead, be consistent, and don't install includes at all during any ofthe libcompat phases, so that we can detect these issues and ensure anyneeded headers are installed for both worldtmp and the system.Reviewed by: brooksDifferential Revision: https://reviews.freebsd.org/D41030 List of files: /freebsd/Makefile.libcompat

537f945fc89fab53f60fee07ac42c8aeab704ce7 - Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make

Sun, 09 Jul 2023 19:46:12 +0200

Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-makeCurrently none of the words in these require quoting, but a futurecommit will add words that do, thus we should make sure to quote eachword so the shell doesn't mangle them before calling the sub-make.(Note that :@var@expr@ is the bmake syntax for map, replacing each wordwith expr's evaluation, with var containing the input word)Reviewed by: emaste, brooks, jhbDifferential Revision: https://reviews.freebsd.org/D40921 List of files: /freebsd/Makefile.libcompat

91d7edd549f52d09dbb12ecf5f0cf2298287f1c8 - Generalise libcompat to be a list rather than a single option

Wed, 28 Jun 2023 01:10:49 +0200

Generalise libcompat to be a list rather than a single optionWhilst the kernel can support any number of COMPAT_FOO, world can onlybuild a single libfoo. Upstream this isn't such an issue, since the onlyoption is lib32 anyway, but downstreams, such as CheriBSD, may wish tosupport multiple at the same time. Thus, adjust the top-level Makefilesto turn _LIBCOMPAT into a _LIBCOMPATS list that gets iterated over, andadjust bsd.compat.mk to support this use-case.For the normal NEED_COMPAT/WANT_COMPAT case, LIBCOMPATFOO remain set andrefer to the requested compat's, preserving the current interface. Forthe top-level Makefiles those variables are no longer set (since thereis no longer "the" compat) and only the per-compat ones are available.Reviewed by: brooks, jhb, impDifferential Revision: https://reviews.freebsd.org/D40571 List of files: /freebsd/Makefile.libcompat

10afc5eada472f7903238c7021a00f722f49a789 - Makefile.libcompat: Handle MK_FOO varying for native and compat arches

Wed, 28 Jun 2023 01:10:30 +0200

Makefile.libcompat: Handle MK_FOO varying for native and compat archesCurrently Makefile.libcompat queries a few MK_FOO variables to determinewhat is being built. However, it is plausible (and indeed, downstreamin CheriBSD, this is the case) that these may vary between the nativeand the compat architecture. In order to correctly determine theirvalues for the compat architecture, we need to defer their evaluationuntil we are in the compat sub-make where src.opts.mk will give us theright value for the compat MACHINE_ARCH.Reviewed by: brooks, jhb, impObtained from: CheriBSDDifferential Revision: https://reviews.freebsd.org/D40570 List of files: /freebsd/Makefile.libcompat

5ed851515129c9c3bfe255baac1c29cb3b041862 - Makefile.libcompat: Remove unused _LC_INCDIRS

Wed, 28 Jun 2023 01:09:44 +0200

Makefile.libcompat: Remove unused _LC_INCDIRSThis is no longer referenced as of commit 724123b9f4d3 ("libcompat: UseWORLDTMP sysroot").Reviewed by: brooks, jhb, impDifferential Revision: https://reviews.freebsd.org/D40569 List of files: /freebsd/Makefile.libcompat

227f47ce0c48acdb466366b136b8c522bb8937e0 - libcompat: avoid installing include files twice

Thu, 17 Nov 2022 01:12:18 +0100

libcompat: avoid installing include files twicePreviously some headers were getting installed twice, once as expectedand then a second time as part of the compat32 library stage.Makefile.libcompat sets -DLIBRARIES_ONLY for the install make invocationwhich causes bsd.lib.mk to skip headers. However some headers arehandled via bsd.prog.mk, which does not use LIBRARIES_ONLY. Explicitlyset MK_INCLUDES=no.Reviewed by: brooksSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D37413 List of files: /freebsd/Makefile.libcompat

ac175bd33a21b7f357cffe37117dc5afa6d7c5fb - Install working pkgconfig .pc files for compat libraries

Fri, 12 Aug 2022 00:17:52 +0200

Install working pkgconfig .pc files for compat librariesThe default ones are install them to /usr/libdata/pkgconfig, and we can'tuse this path for compat libraries, so we use /usr/lib/pkgconfigi here.Test Plan: grep -rn libdir= ./usr/lib32/pkgconfig/*.pcMFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D34939 List of files: /freebsd/Makefile.libcompat

724123b9f4d3ae7600b029ce7c81b5708c1e13b8 - libcompat: Use WORLDTMP sysroot

Fri, 01 Jul 2022 09:33:16 +0200

libcompat: Use WORLDTMP sysrootNow that -m32 is fixed, just install libs in ${WORLDTMP}/lib/lib32and use the installed headers.Reviewed by: imp, jhbObtained from: CheriBSDDifferential Revision: https://reviews.freebsd.org/D34697 List of files: /freebsd/Makefile.libcompat