// SPDX-License-Identifier: GPL-2.0 #include #include #include #include #include "bpf_experimental.h" #include "bpf_misc.h" struct node_acquire { long key; long data; struct bpf_rb_node node; struct bpf_refcount refcount; }; struct node_refcounted { long key; struct bpf_list_node list; struct bpf_refcount refcount; }; struct node_refcount_only { long key; struct bpf_refcount refcount; }; struct map_value_refcount_only { struct node_refcount_only __kptr *node; }; struct rcu_graph_node { struct bpf_rb_node node; long data; }; struct rcu_graph_node *just_here_because_btf_bug; struct map_value_rcu_graph { struct rcu_graph_node __kptr *node; }; extern void bpf_rcu_read_lock(void) __ksym; extern void bpf_rcu_read_unlock(void) __ksym; #define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) private(A) struct bpf_spin_lock glock; private(A) struct bpf_rb_root groot __contains(node_acquire, node); private(B) struct bpf_spin_lock lock; private(B) struct bpf_list_head head __contains(node_refcounted, list); private(C) struct bpf_spin_lock graph_lock; private(C) struct bpf_rb_root graph_root __contains(rcu_graph_node, node); struct { __uint(type, BPF_MAP_TYPE_ARRAY); __type(key, int); __type(value, struct map_value_refcount_only); __uint(max_entries, 1); } stashed_refcount_only SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_ARRAY); __type(key, int); __type(value, struct map_value_rcu_graph); __uint(max_entries, 1); } stashed_rcu_graph SEC(".maps"); static bool less(struct bpf_rb_node *a, const struct bpf_rb_node *b) { struct node_acquire *node_a; struct node_acquire *node_b; node_a = container_of(a, struct node_acquire, node); node_b = container_of(b, struct node_acquire, node); return node_a->key < node_b->key; } SEC("?tc") __failure __msg("Unreleased reference id=4 alloc_insn={{[0-9]+}}") long rbtree_refcounted_node_ref_escapes(void *ctx) { struct node_acquire *n, *m; n = bpf_obj_new(typeof(*n)); if (!n) return 1; bpf_spin_lock(&glock); bpf_rbtree_add(&groot, &n->node, less); /* m becomes an owning ref but is never drop'd or added to a tree */ m = bpf_refcount_acquire(n); bpf_spin_unlock(&glock); if (!m) return 2; m->key = 2; return 0; } SEC("?tc") __failure __msg("Possibly NULL pointer passed to trusted R1") __msg("requires a non-NULL value of type (void *)") long refcount_acquire_maybe_null(void *ctx) { struct node_acquire *n, *m; n = bpf_obj_new(typeof(*n)); /* Intentionally not testing !n * it's MAYBE_NULL for refcount_acquire */ m = bpf_refcount_acquire(n); if (m) bpf_obj_drop(m); if (n) bpf_obj_drop(n); return 0; } SEC("?tc") __failure __msg("R1 is neither owning or non-owning ref") __msg("expects a pointer to a BPF-managed refcounted object, but R1 is a context pointer") long refcount_acquire_non_object(void *ctx) { return bpf_refcount_acquire(ctx) != NULL; } SEC("?syscall") __failure __msg("Possibly NULL pointer passed to trusted R1") long refcount_acquire_rcu_map_kptr_unchecked_drop(void *ctx) { struct map_value_refcount_only *mapval; struct node_refcount_only *tmp, *n, *m; int idx = 0; /* Force Clang to emit complete BTF for struct node_refcount_only. */ tmp = bpf_obj_new(typeof(*tmp)); if (!tmp) return 3; bpf_obj_drop(tmp); mapval = bpf_map_lookup_elem(&stashed_refcount_only, &idx); if (!mapval) return 1; bpf_rcu_read_lock(); n = mapval->node; if (!n) { bpf_rcu_read_unlock(); return 2; } m = bpf_refcount_acquire(n); bpf_rcu_read_unlock(); bpf_obj_drop(m); return 0; } SEC("?syscall") __failure __msg("bpf_rbtree_remove can only take non-owning or refcounted " "bpf_rb_node pointer") long rbtree_remove_after_rcu_unlock(void *ctx) { struct map_value_rcu_graph *mapval; struct bpf_rb_node *rb_node; struct rcu_graph_node *node; int idx = 0; mapval = bpf_map_lookup_elem(&stashed_rcu_graph, &idx); if (!mapval) return 0; bpf_rcu_read_lock(); node = mapval->node; if (!node) { bpf_rcu_read_unlock(); return 0; } bpf_rcu_read_unlock(); bpf_spin_lock(&graph_lock); rb_node = bpf_rbtree_remove(&graph_root, &node->node); bpf_spin_unlock(&graph_lock); if (rb_node) bpf_obj_drop(container_of(rb_node, struct rcu_graph_node, node)); return 0; } SEC("?syscall") __failure __msg("R1 is neither owning or non-owning ref") long refcount_acquire_after_rcu_unlock(void *ctx) { struct map_value_refcount_only *mapval; struct node_refcount_only *node, *ref; int idx = 0; mapval = bpf_map_lookup_elem(&stashed_refcount_only, &idx); if (!mapval) return 0; bpf_rcu_read_lock(); node = mapval->node; if (!node) { bpf_rcu_read_unlock(); return 0; } bpf_rcu_read_unlock(); ref = bpf_refcount_acquire(node); if (ref) bpf_obj_drop(ref); return 0; } SEC("?syscall") __failure __msg("invalid mem access 'scalar'") long graph_kptr_after_spin_unlock(void *ctx) { struct map_value_rcu_graph *mapval; struct rcu_graph_node *node; int idx = 0; mapval = bpf_map_lookup_elem(&stashed_rcu_graph, &idx); if (!mapval) return 0; bpf_spin_lock(&graph_lock); node = mapval->node; if (!node) { bpf_spin_unlock(&graph_lock); return 0; } bpf_spin_unlock(&graph_lock); return node->data; } SEC("?tc") __failure __msg("Unreleased reference id=3 alloc_insn={{[0-9]+}}") long rbtree_refcounted_node_ref_escapes_owning_input(void *ctx) { struct node_acquire *n, *m; n = bpf_obj_new(typeof(*n)); if (!n) return 1; /* m becomes an owning ref but is never drop'd or added to a tree */ m = bpf_refcount_acquire(n); m->key = 2; bpf_spin_lock(&glock); bpf_rbtree_add(&groot, &n->node, less); bpf_spin_unlock(&glock); return 0; } SEC("?tc") __failure __msg("dereference of modified ptr_ ptr R1") long refcount_acquire_list_node_offset(void *ctx) { struct node_refcounted *node, *base, *ref; struct bpf_list_node *list_node; node = bpf_obj_new(typeof(*node)); if (!node) return 1; bpf_spin_lock(&lock); bpf_list_push_front(&head, &node->list); list_node = bpf_list_pop_front(&head); bpf_spin_unlock(&lock); if (!list_node) return 2; base = container_of(list_node, struct node_refcounted, list); ref = bpf_refcount_acquire(list_node); if (ref) bpf_obj_drop(ref); bpf_obj_drop(base); return 0; } SEC("?fentry.s/" SYS_PREFIX "sys_getpgid") __failure __msg("function calls are not allowed while holding a lock") int BPF_PROG(rbtree_fail_sleepable_lock_across_rcu, struct file *file, struct kobject *kobj, struct bin_attribute *bin_attr, char *buf, loff_t off, size_t len) { struct node_acquire *n; n = bpf_obj_new(typeof(*n)); if (!n) return 0; /* spin_{lock,unlock} are in different RCU CS */ bpf_rcu_read_lock(); bpf_spin_lock(&glock); bpf_rbtree_add(&groot, &n->node, less); bpf_rcu_read_unlock(); bpf_rcu_read_lock(); bpf_spin_unlock(&glock); bpf_rcu_read_unlock(); return 0; } char _license[] SEC("license") = "GPL";