//===-- VPlanVerifier.cpp -------------------------------------------------===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// /// /// \file /// This file defines the class VPlanVerifier, which contains utility functions /// to check the consistency and invariants of a VPlan. /// //===----------------------------------------------------------------------===// #include "VPlanVerifier.h" #include "VPlan.h" #include "VPlanCFG.h" #include "VPlanDominatorTree.h" #include "llvm/ADT/DepthFirstIterator.h" #include "llvm/Support/CommandLine.h" #define DEBUG_TYPE "loop-vectorize" using namespace llvm; static cl::opt EnableHCFGVerifier("vplan-verify-hcfg", cl::init(false), cl::Hidden, cl::desc("Verify VPlan H-CFG.")); #ifndef NDEBUG /// Utility function that checks whether \p VPBlockVec has duplicate /// VPBlockBases. static bool hasDuplicates(const SmallVectorImpl &VPBlockVec) { SmallDenseSet VPBlockSet; for (const auto *Block : VPBlockVec) { if (VPBlockSet.count(Block)) return true; VPBlockSet.insert(Block); } return false; } #endif /// Helper function that verifies the CFG invariants of the VPBlockBases within /// \p Region. Checks in this function are generic for VPBlockBases. They are /// not specific for VPBasicBlocks or VPRegionBlocks. static void verifyBlocksInRegion(const VPRegionBlock *Region) { for (const VPBlockBase *VPB : vp_depth_first_shallow(Region->getEntry())) { // Check block's parent. assert(VPB->getParent() == Region && "VPBlockBase has wrong parent"); auto *VPBB = dyn_cast(VPB); // Check block's condition bit. if (VPB->getNumSuccessors() > 1 || (VPBB && VPBB->isExiting())) assert(VPBB && VPBB->getTerminator() && "Block has multiple successors but doesn't " "have a proper branch recipe!"); else assert((!VPBB || !VPBB->getTerminator()) && "Unexpected branch recipe!"); // Check block's successors. const auto &Successors = VPB->getSuccessors(); // There must be only one instance of a successor in block's successor list. // TODO: This won't work for switch statements. assert(!hasDuplicates(Successors) && "Multiple instances of the same successor."); for (const VPBlockBase *Succ : Successors) { // There must be a bi-directional link between block and successor. const auto &SuccPreds = Succ->getPredecessors(); assert(llvm::is_contained(SuccPreds, VPB) && "Missing predecessor link."); (void)SuccPreds; } // Check block's predecessors. const auto &Predecessors = VPB->getPredecessors(); // There must be only one instance of a predecessor in block's predecessor // list. // TODO: This won't work for switch statements. assert(!hasDuplicates(Predecessors) && "Multiple instances of the same predecessor."); for (const VPBlockBase *Pred : Predecessors) { // Block and predecessor must be inside the same region. assert(Pred->getParent() == VPB->getParent() && "Predecessor is not in the same region."); // There must be a bi-directional link between block and predecessor. const auto &PredSuccs = Pred->getSuccessors(); assert(llvm::is_contained(PredSuccs, VPB) && "Missing successor link."); (void)PredSuccs; } } } /// Verify the CFG invariants of VPRegionBlock \p Region and its nested /// VPBlockBases. Do not recurse inside nested VPRegionBlocks. static void verifyRegion(const VPRegionBlock *Region) { const VPBlockBase *Entry = Region->getEntry(); const VPBlockBase *Exiting = Region->getExiting(); // Entry and Exiting shouldn't have any predecessor/successor, respectively. assert(!Entry->getNumPredecessors() && "Region entry has predecessors."); assert(!Exiting->getNumSuccessors() && "Region exiting block has successors."); (void)Entry; (void)Exiting; verifyBlocksInRegion(Region); } /// Verify the CFG invariants of VPRegionBlock \p Region and its nested /// VPBlockBases. Recurse inside nested VPRegionBlocks. static void verifyRegionRec(const VPRegionBlock *Region) { verifyRegion(Region); // Recurse inside nested regions. for (const VPBlockBase *VPB : make_range( df_iterator::begin(Region->getEntry()), df_iterator::end(Region->getExiting()))) { if (const auto *SubRegion = dyn_cast(VPB)) verifyRegionRec(SubRegion); } } void VPlanVerifier::verifyHierarchicalCFG( const VPRegionBlock *TopRegion) const { if (!EnableHCFGVerifier) return; LLVM_DEBUG(dbgs() << "Verifying VPlan H-CFG.\n"); assert(!TopRegion->getParent() && "VPlan Top Region should have no parent."); verifyRegionRec(TopRegion); } // Verify that phi-like recipes are at the beginning of \p VPBB, with no // other recipes in between. Also check that only header blocks contain // VPHeaderPHIRecipes. static bool verifyPhiRecipes(const VPBasicBlock *VPBB) { auto RecipeI = VPBB->begin(); auto End = VPBB->end(); unsigned NumActiveLaneMaskPhiRecipes = 0; const VPRegionBlock *ParentR = VPBB->getParent(); bool IsHeaderVPBB = ParentR && !ParentR->isReplicator() && ParentR->getEntryBasicBlock() == VPBB; while (RecipeI != End && RecipeI->isPhi()) { if (isa(RecipeI)) NumActiveLaneMaskPhiRecipes++; if (IsHeaderVPBB && !isa(*RecipeI)) { errs() << "Found non-header PHI recipe in header VPBB"; #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) errs() << ": "; RecipeI->dump(); #endif return false; } if (!IsHeaderVPBB && isa(*RecipeI)) { errs() << "Found header PHI recipe in non-header VPBB"; #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) errs() << ": "; RecipeI->dump(); #endif return false; } RecipeI++; } if (NumActiveLaneMaskPhiRecipes > 1) { errs() << "There should be no more than one VPActiveLaneMaskPHIRecipe"; return false; } while (RecipeI != End) { if (RecipeI->isPhi() && !isa(&*RecipeI)) { errs() << "Found phi-like recipe after non-phi recipe"; #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) errs() << ": "; RecipeI->dump(); errs() << "after\n"; std::prev(RecipeI)->dump(); #endif return false; } RecipeI++; } return true; } static bool verifyVPBasicBlock(const VPBasicBlock *VPBB, VPDominatorTree &VPDT) { if (!verifyPhiRecipes(VPBB)) return false; // Verify that defs in VPBB dominate all their uses. The current // implementation is still incomplete. DenseMap RecipeNumbering; unsigned Cnt = 0; for (const VPRecipeBase &R : *VPBB) RecipeNumbering[&R] = Cnt++; for (const VPRecipeBase &R : *VPBB) { for (const VPValue *V : R.definedValues()) { for (const VPUser *U : V->users()) { auto *UI = dyn_cast(U); // TODO: check dominance of incoming values for phis properly. if (!UI || isa(UI) || isa(UI)) continue; // If the user is in the same block, check it comes after R in the // block. if (UI->getParent() == VPBB) { if (RecipeNumbering[UI] < RecipeNumbering[&R]) { errs() << "Use before def!\n"; return false; } continue; } if (!VPDT.dominates(VPBB, UI->getParent())) { errs() << "Use before def!\n"; return false; } } } } return true; } bool VPlanVerifier::verifyPlanIsValid(const VPlan &Plan) { VPDominatorTree VPDT; VPDT.recalculate(const_cast(Plan)); auto Iter = vp_depth_first_deep(Plan.getEntry()); for (const VPBasicBlock *VPBB : VPBlockUtils::blocksOnly(Iter)) { if (!verifyVPBasicBlock(VPBB, VPDT)) return false; } const VPRegionBlock *TopRegion = Plan.getVectorLoopRegion(); const VPBasicBlock *Entry = dyn_cast(TopRegion->getEntry()); if (!Entry) { errs() << "VPlan entry block is not a VPBasicBlock\n"; return false; } if (!isa(&*Entry->begin())) { errs() << "VPlan vector loop header does not start with a " "VPCanonicalIVPHIRecipe\n"; return false; } const VPBasicBlock *Exiting = dyn_cast(TopRegion->getExiting()); if (!Exiting) { errs() << "VPlan exiting block is not a VPBasicBlock\n"; return false; } if (Exiting->empty()) { errs() << "VPlan vector loop exiting block must end with BranchOnCount or " "BranchOnCond VPInstruction but is empty\n"; return false; } auto *LastInst = dyn_cast(std::prev(Exiting->end())); if (!LastInst || (LastInst->getOpcode() != VPInstruction::BranchOnCount && LastInst->getOpcode() != VPInstruction::BranchOnCond)) { errs() << "VPlan vector loop exit must end with BranchOnCount or " "BranchOnCond VPInstruction\n"; return false; } for (const VPRegionBlock *Region : VPBlockUtils::blocksOnly( vp_depth_first_deep(Plan.getEntry()))) { if (Region->getEntry()->getNumPredecessors() != 0) { errs() << "region entry block has predecessors\n"; return false; } if (Region->getExiting()->getNumSuccessors() != 0) { errs() << "region exiting block has successors\n"; return false; } } for (const auto &KV : Plan.getLiveOuts()) if (KV.second->getNumOperands() != 1) { errs() << "live outs must have a single operand\n"; return false; } return true; }